[webkit-reviews] review granted: [Bug 137764] Use is<>() / downcast<>() for list-related render objects : [Attachment 239917] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 137764: Use is<>() / downcast<>() for list-related render objects
https://bugs.webkit.org/show_bug.cgi?id=137764

Attachment 239917: Patch
https://bugs.webkit.org/attachment.cgi?id=239917&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239917&action=review


> Source/WebCore/html/HTMLLIElement.cpp:97
>      while (!listNode) {

This loop is so weird.

I would prefer a while(true)+break or a do-while.

> Source/WebCore/rendering/RenderListItem.cpp:155
> +	   Node* otherList = enclosingList(downcast<RenderListItem>(renderer));


Node->Element