[webkit-reviews] review denied: [Bug 137441] Add a test expectations file specific to W3C web platform tests : [Attachment 239320] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied youenn fablet <youennf at gmail.com>'s
request for review:
Bug 137441: Add a test expectations file specific to W3C web platform tests
https://bugs.webkit.org/show_bug.cgi?id=137441

Attachment 239320: Patch
https://bugs.webkit.org/attachment.cgi?id=239320&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239320&action=review


> Tools/Scripts/webkitpy/port/base.py:1032
> -	   return [self.path_to_generic_test_expectations_file()] +
self._port_specific_expectations_files()
> +	   return [self.path_to_generic_test_expectations_file()] +
self._port_specific_expectations_files() +
[self.path_to_w3c_expectations_file()]

I don't think W3C test expectations should override port specific test
expectations.
That would be super confusing.

> LayoutTests/imported/w3c/TestExpectationsW3C:1
> +#imported/w3c/wpt [ Skip ]

This expectation doesn't work because it starts with #.
Does this really need to be at /w3c/?  Can't we move it to
imported/w3c/resources/wpt?
If not, we can add it to the list of names we skip instead.