[webkit-reviews] review granted: [Bug 137353] Add --json flag to test-webkitpy to emit JSON formatted test results on stdout : [Attachment 239878] Fixes style issues

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jake Nielsen
<jake.nielsen.webkit at gmail.com>'s request for review:
Bug 137353: Add --json flag to test-webkitpy to emit JSON formatted test
results on stdout
https://bugs.webkit.org/show_bug.cgi?id=137353

Attachment 239878: Fixes style issues
https://bugs.webkit.org/attachment.cgi?id=239878&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239878&action=review


> Tools/Scripts/webkitpy/test/main.py:85
> +    results['tests'] = sorted(set(all_test_names) -
set(map(operator.itemgetter(0), failures)) - set(map(operator.itemgetter(0),
errors)))

I suggest we name the dictionary key 'passes' since it now represents the list
of tests that pass.

For completeness, there's probably a more space and time efficient way to
compute the list of passing tests. Regardless, this approach to computing the
list of passing tests should be sufficient for our purposes.