[webkit-reviews] review granted: [Bug 137727] Use is<>() / downcast<>() for RenderTextControl / RenderTextControlSingleLine : [Attachment 239838] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 137727: Use is<>() / downcast<>() for RenderTextControl /
RenderTextControlSingleLine
https://bugs.webkit.org/show_bug.cgi?id=137727

Attachment 239838: Patch
https://bugs.webkit.org/attachment.cgi?id=239838&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239838&action=review


> Source/WebCore/page/EventHandler.cpp:3696
> +	   if (auto* renderer = element->renderer()) {
> +	       if (is<RenderTextControlSingleLine>(renderer))

Should either use *renderer here, or eliminate the if that checks renderer for
null.