[webkit-reviews] review denied: [Bug 137586] import-w3c-test rewrites relative src paths in ref files incorrectly : [Attachment 239821] Patch

[bugzilla-daemon at webkit.org]

Bem Jones-Bey <bjonesbe at adobe.com> has denied Rebecca Hauck
<rhauck at adobe.com>'s request for review:
Bug 137586: import-w3c-test rewrites relative src paths in ref files
incorrectly
https://bugs.webkit.org/show_bug.cgi?id=137586

Attachment 239821: Patch
https://bugs.webkit.org/attachment.cgi?id=239821&action=review

------- Additional Comments from Bem Jones-Bey <bjonesbe at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239821&action=review


You need to rebase the patch, it no longer applies. Also, see below.

> Tools/Scripts/webkitpy/w3c/test_converter.py:170
> -	       for attr_name, attr_value in attrs:
> +	       for attr in attrs:

Why the switch here? It seems much more readable to use atter_name and
attr_value instead of attr[0] and attr[1].

> Tools/Scripts/webkitpy/w3c/test_converter.py:171
>		   if attr_name == 'src':

attr_name isn't defined.