[webkit-reviews] review granted: [Bug 137676] Crash in WebCore::UserGestureIndicator::processingUserGesture with WebWorkers : [Attachment 239818] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 14 12:53:51 PDT 2014


Alexey Proskuryakov <ap at webkit.org> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 137676: Crash in WebCore::UserGestureIndicator::processingUserGesture with
WebWorkers
https://bugs.webkit.org/show_bug.cgi?id=137676

Attachment 239818: Patch
https://bugs.webkit.org/attachment.cgi?id=239818&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239818&action=review


Looks good to me. Please wait to EWS to agree :)

> Source/WebCore/dom/UserGestureIndicator.h:46
> +    WEBCORE_EXPORT explicit UserGestureIndicator(ProcessingUserGestureState,
Document* = nullptr);

Maybe add a comment here, explaining that latest user event timestamp is
updated in the document if provided?


More information about the webkit-reviews mailing list