[webkit-reviews] review granted: [Bug 135563] ASSERTION FAILED in WebCore::RenderFlowThread::getRegionRangeForBox : [Attachment 239803] Patch v2

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 135563: ASSERTION  FAILED in
WebCore::RenderFlowThread::getRegionRangeForBox
https://bugs.webkit.org/show_bug.cgi?id=135563

Attachment 239803: Patch v2
https://bugs.webkit.org/attachment.cgi?id=239803&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239803&action=review


Seems ok. If you're trying to catch all things that can change your containing
block, I would actually eyeball the containingBlock() function. transforms can
do it in addition to positioning for example.

> Source/WebCore/rendering/RenderBlock.cpp:319
> +    if (oldStyle && oldStyle->position() != newStyle.position())
> +	   invalidateFlowThreadContainingBlockIncludingDescendants();

transforms can change your containing block too. You may want to include that?