[webkit-reviews] review denied: [Bug 137606] [EFL][GTK] Make it possible to get verbose output with ninja : [Attachment 239626] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonác <ossy at webkit.org> has denied Éva Balázsfalvi
<evab.u-szeged at partner.samsung.com>'s request for review:
Bug 137606: [EFL][GTK] Make it possible to get verbose output with ninja
https://bugs.webkit.org/show_bug.cgi?id=137606

Attachment 239626: Patch
https://bugs.webkit.org/attachment.cgi?id=239626&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239626&action=review


I like the idea, but I think we need some minor fixes.
 
When we use verbose build, we usually do it to be able copy/paste
a command and then run it manually, maybe after some manual editing
or simple check all the command line arguments.

In this case we should disable forcing response files too, see:
http://trac.webkit.org/browser/trunk/Source/cmake/OptionsCommon.cmake#L68

> Tools/Scripts/webkitdirs.pm:1832
> +    push @args, "-v" if $ENV{VERBOSE} or $ENV{V};

I think VERBOSE environment variable is enough, we don't need
two. The makefilegenerator of CMake use VERBOSE also, so it is 
a good choice. V is an autotoolsism, we can avoid using it here.