[webkit-reviews] review denied: [Bug 137155] Native inlining should resolve internal references : [Attachment 239756] The patch for LLVM for adding the pass with the file.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 137155: Native inlining should resolve internal references
https://bugs.webkit.org/show_bug.cgi?id=137155

Attachment 239756: The patch for LLVM for adding the pass with the file. 
https://bugs.webkit.org/attachment.cgi?id=239756&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239756&action=review


> lib/Transforms/Scalar/PrepareForJITInlining.cpp:124
> +    // now simply add a metadata entry which points to this value! 
> +    // metadata will be removed when linking so it won't polute the
namespace.
> +    
> +    std::string MetaTableRefName = RefName + NewGlobSuffix;
> +    NamedMDNode *MetaTableRef = 
> +	 M.getOrInsertNamedMetadata(MetaTableRefName);

So, this creates a symbol table that disappears before the JIT gets to run?  I
don't think that's what you want.