[webkit-reviews] review granted: [Bug 137674] Improve the test image diffs page : [Attachment 239749] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 137674: Improve the test image diffs page
https://bugs.webkit.org/show_bug.cgi?id=137674

Attachment 239749: Patch
https://bugs.webkit.org/attachment.cgi?id=239749&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239749&action=review


> LayoutTests/fast/harness/image-diff-template.html:91
> +    ++preloadedImageCount;
> +    if (preloadedImageCount < 2)
> +	   return;

This is old code, but I don't understand why 2 is the right value here. We are
preloading 3 images.

> LayoutTests/fast/harness/image-diff-template.html:160
> +	   cycleIntervalID = 0;

Could be undefined to match initial value.