[webkit-reviews] review granted: [Bug 137533] MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC : [Attachment 239744] Follow up patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 137533: MediaPlayer::characteristicChanged() is not called when new tracks
are found in SourceBufferPrivateAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=137533

Attachment 239744: Follow up patch
https://bugs.webkit.org/attachment.cgi?id=239744&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239744&action=review


>> Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:58
>> +	EXPECT_TRUE(JSValueIsBoolean(scriptContext, resultValue));
> 
> Won't this cause the test to fail on unsupported platforms?

Oh never mind. Sigh. IsBoolean != ToBoolean.