[webkit-reviews] review denied: [Bug 136938] XMLHttpRequest should have a responseURL attribute (added in recent XHR specification drafts) : [Attachment 239712] Patch-Updated-Review2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Shivakumar J M
<shiva.jm at samsung.com>'s request for review:
Bug 136938: XMLHttpRequest should have a responseURL attribute (added in recent
XHR specification drafts)
https://bugs.webkit.org/show_bug.cgi?id=136938

Attachment 239712: Patch-Updated-Review2
https://bugs.webkit.org/attachment.cgi?id=239712&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239712&action=review


While there are other problems on EWS, the tests do show both of the new tests
failing:

Regressions: Unexpected text-only failures (2)
  http/tests/xmlhttprequest/cross-origin-redirect-responseURL.html [ Failure ]
  http/tests/xmlhttprequest/xmlhttprequest-responseURL.html [ Failure ]

We will have to deal with that before we can commit this to the server. review-
just because of the test failures; otherwise looks fine

> Source/WebCore/ChangeLog:3
> +	   The XMLHttpRequest should suppourt method responseURL As per latest
Spec.

Grammar: XMLHttpRequest does not need a The
Typo: support
Capitalization: as
Capitalize: spec.

responseURL is an attribute, not a method

> Source/WebCore/ChangeLog:12
> +	   The XMLHttpRequest should suppourt method responseURL.

This just repeats the title above and should thus be omitted.