[webkit-reviews] review granted: [Bug 137641] Use is<>() / downcast<>() for Table render objects : [Attachment 239692] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 13 08:04:56 PDT 2014


Mihnea Ovidenie <mihnea at adobe.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 137641: Use is<>() / downcast<>() for Table render objects
https://bugs.webkit.org/show_bug.cgi?id=137641

Attachment 239692: Patch
https://bugs.webkit.org/attachment.cgi?id=239692&action=review

------- Additional Comments from Mihnea Ovidenie <mihnea at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239692&action=review


r=me with the two comments

> Source/WebCore/rendering/AutoTableLayout.cpp:192
> +	       RenderBlock* renderBlock = table->containingBlock();

I believe containingBlock is better than renderBlock here if you want to change
it from cb.

> Source/WebCore/rendering/RenderTableCol.cpp:33
> +#include "RenderTableCaption.h"

Is this include needed?


More information about the webkit-reviews mailing list