[webkit-reviews] review granted: [Bug 137649] Add more detailed wait time information to EWS metrics : [Attachment 239706] proposed patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 137649: Add more detailed wait time information to EWS metrics
https://bugs.webkit.org/show_bug.cgi?id=137649

Attachment 239706: proposed patch
https://bugs.webkit.org/attachment.cgi?id=239706&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239706&action=review


> Tools/ChangeLog:11
> +	   There is always some wait due to polling nature of the queues, which
is well understood

Nit: "due to" => "due to the"

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/M
etricsAnalyzer.js:396
> +	   var patchesThatWaitedMoreThan3Minutes = [];

This is OK as-is. I take it that you find patchesThatWaitedMoreThan3Minutes
reads better than patchesThatWaitedMoreThanThreeMinutes.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/M
etricsBubbleView.js:170
> +	       addLine(this.element,
formatPercentage(this._results.patchesThatWaitedMoreThan3MinutesCount /
this._results.totalPatches) + " of patches had wait time more than 3
minutes.");

Nit: "...had wait time more..." => "...had a wait time of more..."