[webkit-reviews] review granted: [Bug 137597] Support activation behavior of link element : [Attachment 239683] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Dhi Aurrahman
<diorahman at rockybars.com>'s request for review:
Bug 137597: Support activation behavior of link element
https://bugs.webkit.org/show_bug.cgi?id=137597

Attachment 239683: Patch
https://bugs.webkit.org/attachment.cgi?id=239683&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239683&action=review


The page is good, the additional test looks good too.

I have a minor comment. I r+, cq-, which means the patch is good but it cannot
be integrated as it is because of minor review comments.
If you upload a new updated patch, I'll cq+ that one. If I get the chance
tonight I'll just update this version and land manually.

Great job on this bug.

> Source/WebCore/dom/MouseEvent.cpp:193
> +bool MouseEvent::triggerActivationBehavior(const Event* event)

Seeing this being used in practice, the name does not look right. The function
name implies it triggers the Activation Behavior.

I think canTriggerActivationBehavior() would be better.

> Source/WebCore/dom/MouseEvent.h:102
> +    bool static triggerActivationBehavior(const Event*); 

Should be "static bool" instead of "bool static" for WebKit style.

> Source/WebCore/html/HTMLAnchorElement.h:-124
> -

No need to change this line.