[webkit-reviews] review denied: [Bug 137605] [EFL] Make it possible to use ninja for EFL build too : [Attachment 239617] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has denied Éva Balázsfalvi
<evab.u-szeged at partner.samsung.com>'s request for review:
Bug 137605: [EFL] Make it possible to use ninja for EFL build too
https://bugs.webkit.org/show_bug.cgi?id=137605

Attachment 239617: Patch
https://bugs.webkit.org/attachment.cgi?id=239617&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239617&action=review


r- due to missing ninja-build in install-dependency.

> Tools/Scripts/webkitdirs.pm:1763
> +    my $willUseNinja = canUseNinja();

Personally I like to use ninja. To use ninja for EFL, we have to add
ninja-build to EFL install-dependency as well.