[webkit-reviews] review granted: [Bug 137528] [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals : [Attachment 239661] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 137528: [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when
receiving kill/term signals
https://bugs.webkit.org/show_bug.cgi?id=137528

Attachment 239661: Patch
https://bugs.webkit.org/attachment.cgi?id=239661&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239661&action=review


> Tools/LayoutTestRelay/LayoutTestRelay/main.m:103
> +    NSLog(@"FINISHING");

I don't think you want this.

> Tools/Scripts/webkitpy/common/system/executive.py:202
> +		   os.kill(pid, signal.SIGTERM)

This needs a comment I think.