[webkit-reviews] review granted: [Bug 137626] Dashboard metrics page should have EWS statistics : [Attachment 239655] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 137626: Dashboard metrics page should have EWS statistics
https://bugs.webkit.org/show_bug.cgi?id=137626

Attachment 239655: proposed patch
https://bugs.webkit.org/attachment.cgi?id=239655&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239655&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/B
ubbleQueueServer.js:-34
> +	   "gtk-wk2-ews": {platform: Dashboard.Platform.LinuxGTK, shortName:
"gtk-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"},
>	   "mac-ews": {platform: Dashboard.Platform.MacOSXMountainLion,
shortName: "mac", title: "WebKit1\xa0Release\xa0Tests\xa0EWS"},
>	   "mac-wk2-ews": {platform: Dashboard.Platform.MacOSXMountainLion,
shortName: "mac-wk2", title: "WebKit2\xa0Release\xa0Tests\xa0EWS"},
>	   "win-ews": {platform: Dashboard.Platform.Windows7, shortName: "win",
title: "WebKit1\xa0Release\xa0Build\xa0EWS"},
> -	   "gtk-wk2-ews": {platform: Dashboard.Platform.LinuxGTK, shortName:
"gtk-wk2", title: "WebKit2\xa0Release\xa0Build\xa0EWS"},

Why are you moving GTK+ here?

> Tools/QueueStatusServer/handlers/processingtimesjson.py:55
> +	       if not entry.attachment_id in result:
> +		   result[entry.attachment_id] = {}

result.setdefault(entry.attachment_id, {})

> Tools/QueueStatusServer/handlers/processingtimesjson.py:66
> +	   self.response.headers["Access-Control-Allow-Origin"] = "*"

Should we use *.webkit.org & *.apple.com instead?