[webkit-reviews] review granted: [Bug 137562] [EFL] Crash on facebook.com : [Attachment 239556] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 10 10:54:03 PDT 2014


Chris Dumez <cdumez at apple.com> has granted KwangHyuk <hyuki.kim at samsung.com>'s
request for review:
Bug 137562: [EFL] Crash on facebook.com
https://bugs.webkit.org/show_bug.cgi?id=137562

Attachment 239556: Patch
https://bugs.webkit.org/attachment.cgi?id=239556&action=review

------- Additional Comments from Chris Dumez <cdumez at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239556&action=review


> Tools/MiniBrowser/efl/main.c:1531
> +    window->popup.ewk_menu = NULL;

Makes sense but please move this below the elm_menu_close(). It is not nice to
put this in between the elm_menu null check and the elm_menu_close() call.


More information about the webkit-reviews mailing list