[webkit-reviews] review granted: [Bug 137611] Multiple refactors in RenderMathMLOperator : [Attachment 239624] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 10 09:41:28 PDT 2014


Darin Adler <darin at apple.com> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 137611: Multiple refactors in RenderMathMLOperator
https://bugs.webkit.org/show_bug.cgi?id=137611

Attachment 239624: patch
https://bugs.webkit.org/attachment.cgi?id=239624&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239624&action=review


> Source/WebCore/ChangeLog:9
> +	   - Make most of the functions private, we needed to create some API
> +	   and move trailingSpaceError to RenderMathMLOperator.

To be pedantic, the new member functions are needed because of making data
members private, not functions. Also, I personally wouldn't use the term API to
mean public functions here; there’s no “app”.


More information about the webkit-reviews mailing list