[webkit-reviews] review granted: [Bug 137485] [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource : [Attachment 239411] Add new file to EFL build too

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 137485: [GLIB] Split GMainLoopSource moving thread safe implementation to
its own class GThreadSafeMainLoopSource
https://bugs.webkit.org/show_bug.cgi?id=137485

Attachment 239411: Add new file to EFL build too
https://bugs.webkit.org/attachment.cgi?id=239411&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239411&action=review


>>>> Source/WTF/wtf/gobject/GMutexLocker.h:78
>>>> +		  return;
>>> 
>>> Hmm this makes the template useless, because the recursive mutexes will act
as normal ones, won't they?
>> 
>> Hmm this makes the template useless, because the recursive mutexes will act
as normal ones, won't they?
> 
> The idea is that the same GMutexLocker object shouldn't lock a mutex already
locked, but two different GMutexLocker objects, wrapping the same GRecMutex
should be allowed. Which is the case I'm covering here, schedule calls cancel,
both locking the mutex, but using different GMutexLocker objects.

Right. Too many mutexes and lockers :). Couldn't we achieve the same by using
the _try_ variants in MutexWrapper object?