[webkit-reviews] review requested: [Bug 128169] [SOUP] Remove custom URI schemes implementation : [Attachment 239614] Remove custom URI schemes implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 10 03:19:49 PDT 2014


Pascal Jacquemart <p.jacquemart at samsung.com> has asked	for review:
Bug 128169: [SOUP] Remove custom URI schemes implementation
https://bugs.webkit.org/show_bug.cgi?id=128169

Attachment 239614: Remove custom URI schemes implementation
https://bugs.webkit.org/attachment.cgi?id=239614&action=review

------- Additional Comments from Pascal Jacquemart <p.jacquemart at samsung.com>
At least I am glad to see that all ports can now compile with this
CUSTOM_PROTOCOLS flag removal
This patch removes old custom URI schemes implementation, still keeping the
CUSTOM_PROTOCOLS flag

The policy applied is as follow:
#if USE(SOUP) && !ENABLE(CUSTOM_PROTOCOLS) -> Remove
#if !ENABLE(CUSTOM_PROTOCOLS) inside a soup related file -> Remove
#if USE(SOUP) && ENABLE(CUSTOM_PROTOCOLS) -> Keep
#if ENABLE(CUSTOM_PROTOCOLS) -> keep


More information about the webkit-reviews mailing list