[webkit-reviews] review denied: [Bug 137330] RenderMathMLUnderOver adds spacing to the child operator indefinitely when resizing the window : [Attachment 239593] Patch

Thu Oct 9 20:40:14 PDT 2014

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 137330: RenderMathMLUnderOver adds spacing to the child operator
indefinitely when resizing the window
https://bugs.webkit.org/show_bug.cgi?id=137330

Attachment 239593: Patch
https://bugs.webkit.org/attachment.cgi?id=239593&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239593&action=review

> LayoutTests/mathml/opentype/munderover-window-resize-expected.html:1
> +<!DOCTYPE html>

The filename should be changed; this isn't about resize any more, it's about
layout being unstable for some mathml operators.

> LayoutTests/mathml/opentype/munderover-window-resize-expected.html:4
> +  <title>Open Type MATH - under-over operator</title>

We usually don't bother with titles in tests.

> LayoutTests/mathml/opentype/munderover-window-resize-expected.html:5
> +  <meta charset="utf-8">

You don't need this.

> LayoutTests/mathml/opentype/munderover-window-resize-expected.html:7
> +    /* This font is taken from Mozilla's test suite. */

Is the comment necessary?

> LayoutTests/mathml/opentype/munderover-window-resize.html:41
> +	 setTimeout(function(){testRunner.notifyDone();},7000);

We can't have a test take 7s. Imagine if every test took multiple seconds; we
have tens of thousands of them!

You should change this test to do a single layout (foo.style.width = "400px")
which presumably would also show the bug. You can probably do this
synchronously:

<div id="container" style="width: 300px">....

<script>
document.body.offsetWidth; // force initial layout
document.getElementById('container').style.width = "400px";
</script>