[webkit-reviews] review requested: [Bug 137582] Implement selection services menu for Legacy WebKit : [Attachment 239586] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 9 17:59:03 PDT 2014


Tim Horton <thorton at apple.com> has asked  for review:
Bug 137582: Implement selection services menu for Legacy WebKit
https://bugs.webkit.org/show_bug.cgi?id=137582

Attachment 239586: patch
https://bugs.webkit.org/attachment.cgi?id=239586&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
With Anders' changes. However, Anders thinks I should look into putting more of
this in WebCore to share with WebKit2 (so, having the Services ChromeClient
overrides call directly back into WebCore in the Legacy WebKit case, or jump to
the UI process and call back into WebCore in the WebKit2 case, and put the
context menu code/NSSharingServicePicker code in WebCore). I'm not sure this is
going to be super easy so I'm leaving this patch here in case I need to fall
back to it.


More information about the webkit-reviews mailing list