[webkit-reviews] review denied: [Bug 137567] Computed style for clip is wrong with respect to auto : [Attachment 239579] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Dean Jackson
<dino at apple.com>'s request for review:
Bug 137567: Computed style for clip is wrong with respect to auto
https://bugs.webkit.org/show_bug.cgi?id=137567

Attachment 239579: Patch
https://bugs.webkit.org/attachment.cgi?id=239579&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239579&action=review


> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2752
> +	       const Length& top = style->clip().top();
> +	       if (top.isAuto())
> +		  
rect->setTop(cssValuePool().createIdentifierValue(CSSValueAuto));
> +	       else
> +		   rect->setTop(zoomAdjustedPixelValue(top.value(),
style.get()));

Would prefer a little inline function which checks for auto.