[webkit-reviews] review denied: [Bug 137567] Computed style for clip is wrong with respect to auto : [Attachment 239578] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 9 16:34:06 PDT 2014
Brent Fulgham <bfulgham at webkit.org> has denied Dean Jackson <dino at apple.com>'s
request for review:
Bug 137567: Computed style for clip is wrong with respect to auto
https://bugs.webkit.org/show_bug.cgi?id=137567
Attachment 239578: Patch
https://bugs.webkit.org/attachment.cgi?id=239578&action=review
------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239578&action=review
I think we have some copy/paste errors here.
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2760
> + const Length& bottom = style->clip().right();
Is right == bottom here? :-\
> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2766
> + const Length& left = style->clip().right();
Er. left == right? Copy/paste error?
More information about the webkit-reviews
mailing list