[webkit-reviews] review denied: [Bug 137536] [iOS] Add SPI wrapper header for NSGeometry SPI : [Attachment 239490] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 9 15:05:29 PDT 2014


Andy Estes <aestes at apple.com> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 137536: [iOS] Add SPI wrapper header for NSGeometry SPI
https://bugs.webkit.org/show_bug.cgi?id=137536

Attachment 239490: Patch
https://bugs.webkit.org/attachment.cgi?id=239490&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
r- since I don't like how this patch makes NSGeometrySPI.h a Private header in
WebKitLegacy. These headers should only be for our own use. I talked with Dan
in person and we think we devised a way to avoid making this header SPI.


More information about the webkit-reviews mailing list