[webkit-reviews] review granted: [Bug 137570] Remove CrossThreadTask : [Attachment 239565] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 137570: Remove CrossThreadTask
https://bugs.webkit.org/show_bug.cgi?id=137570

Attachment 239565: Patch
https://bugs.webkit.org/attachment.cgi?id=239565&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239565&action=review


> Source/WebCore/ChangeLog:10
> +	   Replace uses of CrossThreadTask with C++11 lambdas. The
initializations
> +	   of cross-thread copies are rather verbose at the moment, but should
look
> +	   better once we can switch to using C++14 init capture for lambdas.

Anders is also working on a project that might lead to cross-thread-safe
reference counting for String. If he succeeds, that will also make many of them
considerably better.

> Source/WebCore/loader/WorkerThreadableLoader.h:108
> +		   virtual void didSendData(unsigned long long bytesSent,
unsigned long long totalBytesToBeSent) override;

Looks like this is indented four spaces too far.