[webkit-reviews] review canceled: [Bug 136351] Web Inspector: timelines should not count time elapsed while paused in the debugger : [Attachment 239446] Patch (Fixed test regressions)

[bugzilla-daemon at webkit.org]

Brian Burg <burg at cs.washington.edu> has canceled Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 136351: Web Inspector: timelines should not count time elapsed while paused
in the debugger
https://bugs.webkit.org/show_bug.cgi?id=136351

Attachment 239446: Patch (Fixed test regressions)
https://bugs.webkit.org/attachment.cgi?id=239446&action=review

------- Additional Comments from Brian Burg <burg at cs.washington.edu>
View in context: https://bugs.webkit.org/attachment.cgi?id=239446&action=review


>> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:176
>> +		    this._legacyFirstRecordTimestamp = recordPayload.startTime;

> 
> What about iOS 8 and earlier with WebInspector.ProfileNodeCall times?

Double checking, but looks like there are a few regressions with this patch
when inspecting iOS 8. Now that I can directly test this use case, I'll post a
revised patch.