[webkit-reviews] review denied: [Bug 131044] REGRESSION(r166395): It made all media tests crash on EFL : [Attachment 239541] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Adrien Destugues
<pulkomandy at gmail.com>'s request for review:
Bug 131044: REGRESSION(r166395): It made all media tests crash on EFL
https://bugs.webkit.org/show_bug.cgi?id=131044

Attachment 239541: Patch
https://bugs.webkit.org/attachment.cgi?id=239541&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239541&action=review


> Source/WebCore/ChangeLog:9
> +	   No new tests: fixes existing tests.
> +	   The pseudo id cannot be set before the elements get a type.

The patch is not necessarily wrong, but the changelog is unsatisfactory.

Here you should explain exactly why the crash occur and why this is the right
fix for it.