[webkit-reviews] review requested: [Bug 137541] Errors using git-add-reviewer on a branch whose name includes parentheses : [Attachment 239548] Fix which doesn't use backticks at all
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 9 10:44:04 PDT 2014
Dana Burkart <dburkart at apple.com> has asked for review:
Bug 137541: Errors using git-add-reviewer on a branch whose name includes
parentheses
https://bugs.webkit.org/show_bug.cgi?id=137541
Attachment 239548: Fix which doesn't use backticks at all
https://bugs.webkit.org/attachment.cgi?id=239548&action=review
------- Additional Comments from Dana Burkart <dburkart at apple.com>
This patch adds a function `runCommandWithOutput` which does the same thing as
backticks, but does not use sh, so we don't have any interpolation problems.
It also fixes a bunch of issues discovered with the use of the system() command
in the script (see above comment).
More information about the webkit-reviews
mailing list