[webkit-reviews] review granted: [Bug 137541] Errors using git-add-reviewer on a branch whose name includes parentheses : [Attachment 239500] Quote arguments to git.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dana Burkart <dburkart at apple.com>'s
request for review:
Bug 137541: Errors using git-add-reviewer on a branch whose name includes
parentheses
https://bugs.webkit.org/show_bug.cgi?id=137541

Attachment 239500: Quote arguments to git.
https://bugs.webkit.org/attachment.cgi?id=239500&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239500&action=review


> Tools/Scripts/git-add-reviewer:311
> +    chomp(my $mergeBase = `git merge-base '$ancestor' '$descendant'`);

This relies on the names not having single quote in them. Is that guaranteed?

> Tools/Scripts/git-add-reviewer:319
> +    chomp(my $commit = `git rev-parse '$arg'`);

This relies on the argument not having a single quote in it. Is that
guaranteed?