[webkit-reviews] review requested: [Bug 137434] [JSC] Segfault on ARM64 with gcc in elf_dynamic_do_Rela : [Attachment 239527] Proposed patch, v2

[bugzilla-daemon at webkit.org]

Akos Kiss <akiss at inf.u-szeged.hu> has asked  for review:
Bug 137434: [JSC] Segfault on ARM64 with gcc in elf_dynamic_do_Rela
https://bugs.webkit.org/show_bug.cgi?id=137434

Attachment 239527: Proposed patch, v2
https://bugs.webkit.org/attachment.cgi?id=239527&action=review

------- Additional Comments from Akos Kiss <akiss at inf.u-szeged.hu>
You're right, .previous works -- on my ARM64/Linux at least. (On that box, I've
been experimenting with some corner cases to check that different compilers --
gcc & clang -- behave as expected, and found no issues, fortunately. I've also
tried out some .pushsection/.popsection-based approaches but all turned out to
need more and potentially harder to maintain changes.) I could not validate the
patch for iOS.

Interestingly, all the other defines use the same .text-based approach for
defining the thunks with no .data/.previous/.pushsection-.popsection around and
noone ran into this problem before. Still I guess that it would be safer to
have .previous in those macros as well, but following the "if it's not broken,
don't fix it" line, I've made no changes there.