[webkit-reviews] review granted: [Bug 137500] StyleQueue should throw a PatchIsNotValid exception to achieve consistency with CommitQueue and EWS : [Attachment 239507] Removes the redundant validate call from StyleQueue

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jake Nielsen
<jake.nielsen.webkit at gmail.com>'s request for review:
Bug 137500: StyleQueue should throw a PatchIsNotValid exception to achieve
consistency with CommitQueue and EWS
https://bugs.webkit.org/show_bug.cgi?id=137500

Attachment 239507: Removes the redundant validate call from StyleQueue
https://bugs.webkit.org/attachment.cgi?id=239507&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239507&action=review


> Tools/Scripts/webkitpy/tool/commands/queues.py:327
> +	       return False

I wonder if we should stop returning values from process_work_item; the caller
doesn't do anything meaningful with them.

> Tools/Scripts/webkitpy/tool/commands/queues.py:467
> +	       return False

And maybe ones in review_patch functions too. It's quite confusing that each
subclass is responsible to all results except for _did_pass, it seems better to
make them call _did_pass, too.