[webkit-reviews] review denied: [Bug 137521] [WinCairo] Enable JIT on 32-bit. : [Attachment 239483] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 8 12:25:29 PDT 2014


Mark Lam <mark.lam at apple.com> has denied peavo at outlook.com's request for
review:
Bug 137521: [WinCairo] Enable JIT on 32-bit.
https://bugs.webkit.org/show_bug.cgi?id=137521

Attachment 239483: Patch
https://bugs.webkit.org/attachment.cgi?id=239483&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239483&action=review


Looks good but please fix the ChangeLog comments.  Thanks.

> Source/JavaScriptCore/ChangeLog:8
> +	   Enable JIT on Windows 32-bit, but disable it runtime if SSE2 is not
present.

typo": disable it *at* runtime

> Source/WTF/ChangeLog:8
> +	   Enable JIT on Windows 32-bit, but disable it runtime if SSE2 is not
present.

ditto.	Please fix comment.


More information about the webkit-reviews mailing list