[webkit-reviews] review denied: [Bug 137195] [WK2][EFL] Fix not destroyed thread created by DispatchQueueEfl even after the DispatchQueueEfl has been destructed : [Attachment 239390] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has denied Joonghun Park
<jh718.park at samsung.com>'s request for review:
Bug 137195: [WK2][EFL] Fix not destroyed thread created by DispatchQueueEfl
even after the DispatchQueueEfl has been destructed
https://bugs.webkit.org/show_bug.cgi?id=137195

Attachment 239390: Patch
https://bugs.webkit.org/attachment.cgi?id=239390&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239390&action=review


> Source/WebKit2/ChangeLog:3
> +	   [WK2][EFL] Fix not destroyed thread created by DispatchQueueEfl even
after the DispatchQueueEfl has been destructed

Not clear bug title.

> Source/WebKit2/ChangeLog:8
> +	   Linux and Unix System's pthread is created in joinable state by
default.

I don't get this patch description. Please improve it further.

> Source/WebKit2/ChangeLog:10
> +	   The call to waitForThreadCompletion() in ~DispatchQueue() is for
this purpose.

I don't read this sentence.

> Source/WebKit2/Platform/efl/DispatchQueueEfl.h:67
> +    ThreadIdentifier m_threadID;

If you declare this below bool m_isThreadRunning, you don't need to change
m_isThreadRunning in DispatchQueue::DispatchQueue()