[webkit-reviews] review granted: [Bug 137048] Implement WKPageIsPlayingAudio() : [Attachment 239421] Updated patch: this time using git diff.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 7 21:55:38 PDT 2014
Darin Adler <darin at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 137048: Implement WKPageIsPlayingAudio()
https://bugs.webkit.org/show_bug.cgi?id=137048
Attachment 239421: Updated patch: this time using git diff.
https://bugs.webkit.org/attachment.cgi?id=239421&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239421&action=review
> Tools/TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:77
> + WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());
Please use the adoptWK() function instead of the AdoptWK constructor, since
we’d like to delete it eventually.
More information about the webkit-reviews
mailing list