[webkit-reviews] review granted: [Bug 134854] Safari 8 on OSX 10.10 does not run WebGL in Retina HiDPI mode. : [Attachment 239445] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 134854: Safari 8 on OSX 10.10 does not run WebGL in Retina HiDPI mode.
https://bugs.webkit.org/show_bug.cgi?id=134854

Attachment 239445: Patch
https://bugs.webkit.org/attachment.cgi?id=239445&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239445&action=review


> Source/WebCore/ChangeLog:20
> +

- we don't believe in pixel tests?

> Source/WebCore/platform/graphics/GraphicsContext3D.h:445
> +	       , devicePixelRatio(1.0)

just 1, I think?

> Source/WebCore/platform/graphics/mac/WebGLLayer.mm:53
> +    self.contentsScale = _devicePixelRatio;

why is iOS special here?