[webkit-reviews] review granted: [Bug 137460] Commit queue doesn't drop obsolete patches sometimes : [Attachment 239428] Integrates Csaba's unit test, and makes the validation codepath use exceptions to report invalid patches.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 7 13:33:02 PDT 2014


Alexey Proskuryakov <ap at webkit.org> has granted Jake Nielsen
<jake.nielsen.webkit at gmail.com>'s request for review:
Bug 137460: Commit queue doesn't drop obsolete patches sometimes
https://bugs.webkit.org/show_bug.cgi?id=137460

Attachment 239428: Integrates Csaba's unit test, and makes the validation
codepath use exceptions to report invalid patches.
https://bugs.webkit.org/attachment.cgi?id=239428&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239428&action=review


>> Tools/ChangeLog:26
>> +	    exception.
> 
> Should we also remove the call to validate() in StyleQueue.review_patch()?
This patch changes commit queue and EWS, including some code that is shared
between style queue and EWS, but it doesn't fully clean up the style queue.

Actually, I guess it doesn't touch the style queue.


More information about the webkit-reviews mailing list