[webkit-reviews] review granted: [Bug 137472] [Media] Expose AudioTracks in the "captions" menu. : [Attachment 239380] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 137472: [Media] Expose AudioTracks in the "captions" menu.
https://bugs.webkit.org/show_bug.cgi?id=137472

Attachment 239380: Patch
https://bugs.webkit.org/attachment.cgi?id=239380&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239380&action=review


I'm worried that we need to flesh out the AudioTrack stuff on Windows; there
isn't any such thing as an AudioTrackPrivateAVCF/VideoTrackPrivateAVCF.
Otherwise, this looks great! Let's get it landed and if anything breaks on
Windows I'll clean it up during my ongoing media work.

> Source/WebCore/html/track/AudioTrack.cpp:-150
> -    setEnabled(enabled);

Just Curious: Why don't we want to recurse into the private 'setEnabled' here?
What problem does that fix?

> Source/WebCore/page/CaptionUserPreferences.cpp:228
> +    });

Oooh!  A lambda! :-)