[webkit-reviews] review canceled: [Bug 137483] [webkitpy] CQ- should mean not valid patch for commit queue : [Attachment 239406] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 7 09:55:22 PDT 2014
Csaba Osztrogonác <ossy at webkit.org> has canceled Csaba Osztrogonác
<ossy at webkit.org>'s request for review:
Bug 137483: [webkitpy] CQ- should mean not valid patch for commit queue
https://bugs.webkit.org/show_bug.cgi?id=137483
Attachment 239406: Patch
https://bugs.webkit.org/attachment.cgi?id=239406&action=review
------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239406&action=review
>> Tools/Scripts/webkitpy/tool/bot/commitqueuetask.py:54
>> + return False
>
> What code checks that flag hasn't been changed back to "cq?"? Perhaps there
is a separate check somewhere that cq+ is still set?
Good point, there isn't a separate check for it.
More information about the webkit-reviews
mailing list