[webkit-reviews] review granted: [Bug 137460] Commit queue doesn't drop obsolete patches sometimes : [Attachment 239363] Adds a call to task.validate() and handles invalid tasks in the same way that EWS does.

[bugzilla-daemon at webkit.org]

Csaba Osztrogonác <ossy at webkit.org> has granted Jake Nielsen
<jake.nielsen.webkit at gmail.com>'s request for review:
Bug 137460: Commit queue doesn't drop obsolete patches sometimes
https://bugs.webkit.org/show_bug.cgi?id=137460

Attachment 239363: Adds a call to task.validate() and handles invalid tasks in
the same way that EWS does.
https://bugs.webkit.org/attachment.cgi?id=239363&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
I checked, it is the right fix, EWS and style queue do the same thing.

task.run() also calls validate, but it simply returns with false
and then the patch is unlocked, but not removed from the queue.

We should validate at the beginning and then call _did_error
to remove the task from the queue.

r=me, but I agree, we should add a unittest for it.