[webkit-reviews] review granted: [Bug 128177] [EFL] Switch to CUSTOM_PROTOCOLS : [Attachment 239211] After Gyuyoung review (v3)

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Pascal Jacquemart
<p.jacquemart at samsung.com>'s request for review:
Bug 128177: [EFL] Switch to CUSTOM_PROTOCOLS
https://bugs.webkit.org/show_bug.cgi?id=128177

Attachment 239211: After Gyuyoung review (v3)
https://bugs.webkit.org/attachment.cgi?id=239211&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239211&action=review


LGTM. I think GTK port already uses CUSTOM_PROTOCOLS on soup backend by
default. EFL port needs to follow it as well. However, someone might want to
have final look before landing.

> Source/WebKit2/PlatformEfl.cmake:-172
> -    UIProcess/soup/WebSoupRequestManagerClient.cpp

If EFL port doesn't use it as well, I think nobody uses this file, right ? Then
we have to remove it.

> Source/WebKit2/PlatformEfl.cmake:-173
> -    UIProcess/soup/WebSoupRequestManagerProxy.cpp

ditto.

> Source/WebKit2/PlatformEfl.cmake:-206
> -    WebProcess/soup/WebSoupRequestManager.cpp

ditto.

> Source/WebKit2/PlatformEfl.cmake:-212
> -    UIProcess/soup/WebSoupRequestManagerProxy.messages.in

ditto.

> Source/WebKit2/PlatformEfl.cmake:-215
> -

ditto.