[webkit-reviews] review granted: [Bug 137471] [Win] Use of 1-bit Enum type behaves improperly : [Attachment 239369] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 137471: [Win] Use of 1-bit Enum type behaves improperly
https://bugs.webkit.org/show_bug.cgi?id=137471

Attachment 239369: Patch
https://bugs.webkit.org/attachment.cgi?id=239369&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239369&action=review


r=me with the comment added.

> Source/JavaScriptCore/debugger/Debugger.h:195
> +    unsigned m_steppingMode : 1;

I recall Darin saying that the accepted practice is to add a trailing comment
to indicate the expected type:

unsigned m_steppingMode : 1; // SteppingMode