[webkit-reviews] review granted: [Bug 137424] Add is<>() / downcast<>() support for RenderObject subclasses : [Attachment 239289] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 137424: Add is<>() / downcast<>() support for RenderObject subclasses
https://bugs.webkit.org/show_bug.cgi?id=137424

Attachment 239289: Patch
https://bugs.webkit.org/attachment.cgi?id=239289&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239289&action=review


lgtm.

> Source/WebCore/rendering/RenderIterator.h:76
> +// Similar to WTF::is<>() but without the static_assert() making sure
> +// the check is necessary.

One line.

> Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:157
> +	       if (parentBlock.isRenderMathMLScriptsWrapper()) {

No is<RenderMathMLScriptsWrapper>?