[webkit-reviews] review granted: [Bug 135205] [Win] Lots of compiler warnings on Windows : [Attachment 239361] the patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 6 15:11:47 PDT 2014


Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 135205: [Win] Lots of compiler warnings on Windows
https://bugs.webkit.org/show_bug.cgi?id=135205

Attachment 239361: the patch.
https://bugs.webkit.org/attachment.cgi?id=239361&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239361&action=review


r=me

> Source/JavaScriptCore/dfg/DFGArgumentPosition.h:67
> +	   return checkAndSet(m_shouldNeverUnbox, m_shouldNeverUnbox ||
shouldNeverUnbox);

Why is this needed?


More information about the webkit-reviews mailing list