[webkit-reviews] review granted: [Bug 137220] Add a ChromeClient API that gets called whenever the Page's audio playing state has changed : [Attachment 239344] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 137220: Add a ChromeClient API that gets called whenever the Page's audio
playing state has changed
https://bugs.webkit.org/show_bug.cgi?id=137220

Attachment 239344: Patch
https://bugs.webkit.org/attachment.cgi?id=239344&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239344&action=review


r=me, with nit.

> Source/WebCore/page/ChromeClient.h:434
> +    virtual void isPlayingAudioDidChange(bool /*newIsPlayingAudio*/) { }

Nit: You don't need to include the (commented out) parameter name here. It's
obvious from the function name.