[webkit-reviews] review denied: [Bug 137446] [jhbuild] We should be able to disable wiping on configuration change : [Attachment 239324] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 6 03:35:09 PDT 2014


Csaba Osztrogonác <ossy at webkit.org> has denied Tibor Mészáros
<tmeszaros.u-szeged at partner.samsung.com>'s request for review:
Bug 137446: [jhbuild] We should be able to disable wiping on configuration
change
https://bugs.webkit.org/show_bug.cgi?id=137446

Attachment 239324: Patch
https://bugs.webkit.org/attachment.cgi?id=239324&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
The patch looks good to me, but the comment is misleading.

$wipeOnChange has true default value, but can be disabled with
- JHBUILD_WIPE_ON_CHANGE=0 environment variable (or)
- --no-wipe-on-change command line option


More information about the webkit-reviews mailing list