[webkit-reviews] review granted: [Bug 137438] Use is<>() / downcast<>() for TextTrack subclasses : [Attachment 239308] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Oct 5 21:35:06 PDT 2014
Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 137438: Use is<>() / downcast<>() for TextTrack subclasses
https://bugs.webkit.org/show_bug.cgi?id=137438
Attachment 239308: Patch
https://bugs.webkit.org/attachment.cgi?id=239308&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=239308&action=review
> Source/WebCore/html/track/TextTrackList.cpp:54
> -int TextTrackList::getTrackIndex(TextTrack *textTrack)
> +int TextTrackList::getTrackIndex(TextTrack* textTrack)
We don't have to do it in this patch but we should use reference for textTrack.
More information about the webkit-reviews
mailing list