[webkit-reviews] review granted: [Bug 137361] [GTK] Fix build when DRAG_SUPPORT is disabled : [Attachment 239297] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 5 01:21:51 PDT 2014


Carlos Garcia Campos <cgarcia at igalia.com> has granted Lorenzo Tilve
<ltilve at igalia.com>'s request for review:
Bug 137361: [GTK] Fix build when DRAG_SUPPORT is disabled
https://bugs.webkit.org/show_bug.cgi?id=137361

Attachment 239297: Patch
https://bugs.webkit.org/attachment.cgi?id=239297&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=239297&action=review


> Source/WebKit2/Shared/gtk/ArgumentCodersGtk.h:47
>  template<> struct ArgumentCoder<WebCore::DragData> {
> +#if ENABLE(DRAG_SUPPORT)
>      static void encode(ArgumentEncoder&, const WebCore::DragData&);
>      static bool decode(ArgumentDecoder&, WebCore::DragData&);
> +#endif
>  };

Why are the ifdefs inside the struct instead of the whole struct definition
inside the #ifdef block?


More information about the webkit-reviews mailing list